huizhilu commented on a change in pull request #1744:
URL: https://github.com/apache/helix/pull/1744#discussion_r633833813
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -129,13 +129,19 @@
* 4. select the messages that can be sent, needs messages and state model
constraints <br>
* 5. send messages
*/
-public class GenericHelixController implements IdealStateChangeListener,
LiveInstanceChangeListener,
- MessageListener,
CurrentStateChangeListener,
+public class GenericHelixController implements IdealStateChangeListener,
+ LiveInstanceChangeListener,
+ MessageListener,
+ CurrentStateChangeListener,
TaskCurrentStateChangeListener,
CustomizedStateRootChangeListener,
CustomizedStateChangeListener,
- CustomizedStateConfigChangeListener, ControllerChangeListener,
- InstanceConfigChangeListener, ResourceConfigChangeListener,
ClusterConfigChangeListener {
+
CustomizedStateConfigChangeListener,
+ ControllerChangeListener,
+ InstanceConfigChangeListener,
+ ResourceConfigChangeListener,
+ ClusterConfigChangeListener,
+ ClusterPauseChangeListener {
Review comment:
Only ClusterPause needs a dataChange listener for exiting pause, because
controller needs to wait for participants fully exited. The other 2: controller
pause and maintenance don't need the data change listener, as they are simply
deleted for exiting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
