NealSun96 commented on a change in pull request #1736:
URL: https://github.com/apache/helix/pull/1736#discussion_r634613265
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -362,6 +363,7 @@ private void carryOverPreviousCurrentState() {
}
// If the the current state is related to tasks, there is no need to
carry it over to new session.
+ // Note: this check is not necessary due to TaskCurrentStates, but
keep it for backwards compatibility
Review comment:
Because this logic is working with `_keyBuilder.currentStates`.
TaskCurrentStates have their own path now (`keyBuilder.taskCurrentStates`),
meaning this check will not be used unless for backward compatibility purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
