jiajunwang commented on a change in pull request #1750:
URL: https://github.com/apache/helix/pull/1750#discussion_r638395639
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/stages/TestRecoveryLoadBalance.java
##########
@@ -57,7 +57,10 @@
private final String STATE_MODEL = "statemodel";
private ClusterConfig _clusterConfig;
- @Test(dataProvider = "recoveryLoadBalanceInput")
+ // Disable the test since recovery rebalance is not able to block load
rebalance.
+ // TODO: if we decide to support that by replica level, we will have a
different config for that and this test can be
Review comment:
I would suggest removing this test given we already have test coverage.
First, there is no plan or discussion about re-enabling it. Secondly, I think
simply block loadbalance because of recovery without considering throttling is
not correct behavior. If we are going to do a similar restriction, we would do
it through throttling anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
