junkaixue commented on a change in pull request #1812:
URL: https://github.com/apache/helix/pull/1812#discussion_r667389270
##########
File path:
helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java
##########
@@ -146,18 +147,29 @@ private void sendNopMessage() {
@Override
public void reset() {
- logger.info("Resetting HelixStateMachineEngine");
+ loopStateModelFactories(stateModel -> {
+ stateModel.reset();
+ String initialState =
_stateModelParser.getInitialState(stateModel.getClass());
+ stateModel.updateState(initialState);
+ }, "reset");
Review comment:
It will never be too heavy for this. Hard code is not a good idea except
in test cases. If we would like to change some logic in the future. We dont
have the centralized place to trace back when these logic happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
