huizhilu commented on a change in pull request #1816:
URL: https://github.com/apache/helix/pull/1816#discussion_r669986519
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/ManagementMessageGenerationPhase.java
##########
@@ -96,7 +96,9 @@ public void process(ClusterEvent event) throws Exception {
LiveInstance liveInstance = liveInstanceMap.get(instanceName);
Collection<Message> pendingMessages =
allInstanceMessages.get(instanceName);
String sessionId = liveInstance.getEphemeralOwner();
- LiveInstanceStatus currentStatus = liveInstance.getStatus();
+ LiveInstanceStatus liveInstanceStatus = liveInstance.getStatus();
Review comment:
Synced offline. Returning null or normal isn't a big issue. As
@jiajunwang said, to simplify the business logic, I'll make the change to
return NORMAL in next PR, combined with the refactoring work, making it easy to
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
