rabashizade opened a new pull request #1926:
URL: https://github.com/apache/helix/pull/1926


   Adds dependency to Zookeeper in the ivy file in zookeeper-api module.
   
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the 
PR description:
   
   Fixes #1925 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   This PR declares dependency to Zookeeper in the ivy file of the 
zookeeper-api module. Since zookeeper-api needs classes from Zookeeper, the 
absence of this dependency in the ivy file causes compilation error on some 
systems. By adding this dependency, the compilation error is resolved.
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   None
   
   - The following is the result of the "mvn test" command on the appropriate 
module:
   
   No changes to the code were made.
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their 
subject lines. In addition, my commits follow the guidelines from "[How to 
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to