narendly commented on PR #2016: URL: https://github.com/apache/helix/pull/2016#issuecomment-1092878856
Great work! One suggestion: when this gets merged into master, we will not be squashing the commits to preserve them. As such, you might want to squash all of your own commits on top of the previous author's commit so that it's just one single commit that makes it mergeable back into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
