xyuanlu commented on PR #2035: URL: https://github.com/apache/helix/pull/2035#issuecomment-1099657871
> The impl looks good with minor comments, but here are some general questions on the design. Could you share more context on why the service silently fail? Also I'm wondering if a null value makes sense in the first place. Will something like a default or empty value be better? Thanks for the reply. If we get null for MaintenanceManagementInstanceInfo, then in MaintenanceManagementService.takeFreeSingleInstanceHelper() will throw npr exception causing operation failure. This function execute user implemented interface `OperationInterface`. It should make sense to allow other user to return null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
