micahstubbs opened a new pull request, #2054: URL: https://github.com/apache/helix/pull/2054
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fix #2053 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: This PR upgrades helix-front to Angular 13. In order to do this, it upgrades many other dependencies, and makes necessary code changes in response to breaking changes from dependencies. This PR also fixes or ignores TypeScript and Linting errors that arise when upgrading type-checking and linting tools. ### Tests - [x] The following tests are written for this issue: No new tests. <!--- The following is the result of the "mvn test" command on the appropriate module: (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ---> Currently work in progress. There is one known build failure in the `yarn build` script, documented by two existing Angular community StackOverflow questions: - [Mixins / Webpack issues after upgrading to Angular 13](https://stackoverflow.com/questions/71287728/mixins-webpack-issues-after-upgrading-to-angular-13) - [editor.component.scss:17:100: ERROR: Unterminated string token - Angular + Scss](https://stackoverflow.com/questions/71916458/editor-component-scss17100-error-unterminated-string-token-angular-scss) ### Changes that Break Backward Compatibility (Optional) N/A ### Documentation (Optional) No new functionality, only dependency upgrades to unblock development for future new functionality. <!--- ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
