junkaixue commented on code in PR #2073:
URL: https://github.com/apache/helix/pull/2073#discussion_r861385353
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java:
##########
@@ -514,7 +515,7 @@ public void disconnect() {
try {
ParticipantHistory history = getHistory();
history.reportOffline();
- persistHistory(history);
+ persistHistory(history, true);
Review Comment:
Why this is true? If disconnect, we are giving up the node and if instance
has been dropped between zk connection disconnect and this call, we will still
create that.
It would be meaning less if there was a path does not exist and update this
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
