qqu0127 commented on code in PR #2086:
URL: https://github.com/apache/helix/pull/2086#discussion_r868468809
##########
bump-up.command:
##########
@@ -19,6 +19,30 @@
# under the License.
#
+MODULES=("metrics-common" "metadata-store-directory-common" "zookeeper-api"
"helix-common" "helix-core" \
+"helix-admin-webapp" "helix-front" "helix-rest" "helix-lock"
"helix-view-aggregator" "helix-agent")
+
+update_pom_version() {
+ pom=$1
+ echo "bump up $pom"
+ sed -i "s/${version}/${new_version}/g" $pom
Review Comment:
Hey @narendly , thanks for the comment.
Not sure if I understand it correctly, but it seems `sed` doesn't complain
if the pattern is not found. We actually need to do extra work to make it error
out in such case
https://unix.stackexchange.com/questions/55810/is-there-an-option-to-make-sed-fail-if-pattern-not-found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
