[GitHub] [helix] micahstubbs opened a new pull request, #2087: Upgrade helix-front to Angular 7.2

Tue, 10 May 2022 16:44:02 -0700 


micahstubbs opened a new pull request, #2087:
URL: https://github.com/apache/helix/pull/2087

   ### Issues
   
   #2084 
   
   ### Description
   
   This PR upgrades to Angular 7.2. This PR completely contains #2078 and #2083 
which should be merged first.
   
   ### Tests
   
   Let's test the upgrade from Angular 6.1 to Angular 7.2:
   
   - [x] `npm install` works
   - [x] `npm rm type:check:watch` shows 0 TypeScript errors
   - [x] `npm run lint` runs and passes `All files pass linting.`
   - [x] `npm run build` works
   - [x] `npm start` works, with 0 errors in the browser console.
   - [x] `npm run test` appears to work. 
   
   `npm start` works as expected, and recognizes our proxy config in 
`proxy.conf.json`.
   
   <img width="687" alt="Screen Shot 2022-05-10 at 4 16 46 PM" 
src="https://user-images.githubusercontent.com/2119400/167740073-f124219d-497b-49f3-8209-da14817cda6b.png";>
   
   Helix UI renders with XX errors and YY warning in the browser console. The 
warning is understandable since the piwik telemetry library is not configured. 
   
   `npm run test` results
   
   <img width="750" alt="Screen Shot 2022-05-10 at 4 17 10 PM" 
src="https://user-images.githubusercontent.com/2119400/167740107-779cc161-f84b-4cd6-84a6-5d333169a997.png";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to