micahstubbs opened a new pull request, #2089: URL: https://github.com/apache/helix/pull/2089
### Issues Fix #2088 ### Description This PR upgrades to Angular 8.2. This PR completely contains earlier helix-front upgrade PRs #2087, https://github.com/apache/helix/pull/2078, and https://github.com/apache/helix/pull/2083. These previous Angular major-version PRs should be merged first. ### Tests Let's test the upgrade from Angular 7.2 to Angular 8.2. - [x] `npm install` works - [x] `npm rm type:check:watch` shows 0 TypeScript errors - [x] `npm run lint` runs and passes `All files pass linting.` - [x] `npm run build` works - [x] `npm start` works, with 0 errors in the browser console. - [x] `npm run test` runs and passes. `npm start` works as expected, and recognizes our proxy config in `proxy.conf.json`. <img width="692" alt="Screen Shot 2022-05-11 at 2 51 54 PM" src="https://user-images.githubusercontent.com/2119400/167954001-cdfd3795-2f16-4853-a832-dffb84634386.png";> Helix UI renders with 0 errors and 1 warning in the browser console. The warning is understandable since the piwik telemetry library is not configured. `npm run test` results <img width="736" alt="Screen Shot 2022-05-11 at 2 53 49 PM" src="https://user-images.githubusercontent.com/2119400/167954050-55ca8626-b38d-418c-bdcb-c456cf287a3d.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/2119400/167954001-cdfd3795-2f16-4853-a832-dffb84634386.png"](https://user-images.githubusercontent.com/2119400/167954001-cdfd3795-2f16-4853-a832-dffb84634386.png"){kind=link}
![https://user-images.githubusercontent.com/2119400/167954050-55ca8626-b38d-418c-bdcb-c456cf287a3d.png"](https://user-images.githubusercontent.com/2119400/167954050-55ca8626-b38d-418c-bdcb-c456cf287a3d.png"){kind=link}