narendly commented on code in PR #2090:
URL: https://github.com/apache/helix/pull/2090#discussion_r871420659
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/IZkConnection.java:
##########
@@ -40,6 +40,8 @@ public interface IZkConnection {
public String create(String path, byte[] data, List<ACL> acl, CreateMode
mode) throws KeeperException, InterruptedException;
+ public String create(String path, byte[] data, List<ACL> acl, CreateMode
mode, long ttl) throws KeeperException, InterruptedException;
Review Comment:
This is a general comment. Now with this PR, I think it would be beneficial
to add some basic tests such as creating using the newly added modes (TTL,
container). Since ZK doesn't guarantee how long it would take to delete and
there is no good way to tell whether the znode is created on TTL post-creation,
I think read/write, checking that creation and deletion went through, would be
beneficial. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
