desaikomal commented on code in PR #2097:
URL: https://github.com/apache/helix/pull/2097#discussion_r873881573
##########
helix-rest/src/test/java/org/apache/helix/rest/server/TestAuthValidator.java:
##########
@@ -54,9 +55,18 @@ public class TestAuthValidator extends AbstractTestClass {
private String _mockBaseUri;
private CloseableHttpClient _httpClient;
+ private static String CLASSNAME_TEST_DEFAULT_AUTH =
"testDefaultAuthValidator";
+ private static String CLASSNAME_TEST_CST_AUTH = "testCustomAuthValidator";
+
+ @AfterClass
+ public void afterClass() {
Review Comment:
sorry for my ignorance, but shouldn't we be deleting Helix Cluster, rather
than directly using zkclient to delete znodes?
##########
helix-rest/src/test/java/org/apache/helix/rest/server/TestAuthValidator.java:
##########
@@ -54,9 +55,18 @@ public class TestAuthValidator extends AbstractTestClass {
private String _mockBaseUri;
private CloseableHttpClient _httpClient;
+ private static String CLASSNAME_TEST_DEFAULT_AUTH =
"testDefaultAuthValidator";
+ private static String CLASSNAME_TEST_CST_AUTH = "testCustomAuthValidator";
+
+ @AfterClass
+ public void afterClass() {
+ _gZkClient.deleteRecursively("/" + CLASSNAME_TEST_DEFAULT_AUTH);
+ _gZkClient.deleteRecursively("/" + CLASSNAME_TEST_CST_AUTH);
+ }
+
@Test
public void testDefaultAuthValidator() throws JsonProcessingException {
- String testClusterName = "testDefaultAuthValidator";
+ String testClusterName = CLASSNAME_TEST_DEFAULT_AUTH;
Review Comment:
to be honest, you don't need another copy of the same string, directly use
CLASSNAME_TEST_DEFAULT_AUTH..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
