[GitHub] [helix] micahstubbs opened a new pull request, #2115: 2114/upgrade to angular 13.3

Tue, 24 May 2022 01:13:08 -0700 


micahstubbs opened a new pull request, #2115:
URL: https://github.com/apache/helix/pull/2115

   ### Description
   
   This PR upgrades helix-front to Angular 13.3.
   
   This PR completely contains earlier helix-front upgrade PRs #2113, #2111, 
#2104, #2094, #2092, #2087, #2083, and #2078. These previous Angular 
major-version PRs should be merged first.
   
   ### Issue
   
   Fix #2114 
   
   ### Tests
   
   Let's test the upgrade from Angular 12.2 to Angular 13.3.
   
   - [x] `yarn` successfully installs dependencies
   - [x] `yarn type:check:watch` shows 0 TypeScript errors
   - [x] `yarn lint` runs and passes `All files pass linting.`
   - [x] `yarn build` works
   - [x] `yarn start` works, with 0 errors in the browser console.
   - [x] `yarn test` runs and passes.
   
   `yarn start` works as expected, and recognizes our proxy config in 
`proxy.conf.json`.  The Helix UI renders with 0 errors in the browser console.  
   
   <img width="726" alt="Screen Shot 2022-05-24 at 12 51 42 AM" 
src="https://user-images.githubusercontent.com/2119400/169982366-9906be2e-b053-497e-928a-cbc0a0b3ca86.png";>
   
   `yarn test` results
   
   <img width="752" alt="Screen Shot 2022-05-24 at 1 08 23 AM" 
src="https://user-images.githubusercontent.com/2119400/169982414-5282afad-7d8a-432c-a4e2-4886d622354d.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to