xyuanlu commented on code in PR #2121:
URL: https://github.com/apache/helix/pull/2121#discussion_r882180761
##########
helix-core/src/test/java/org/apache/helix/cloud/event/TestCloudEventCallbackProperty.java:
##########
@@ -188,7 +193,7 @@ public void testUsingInvalidImplClassName() throws
Exception {
_helixManager.connect();
// Manually trigger event
- CloudEventHandlerFactory.getInstance()
+ ((CloudEventHandler)
CloudEventHandlerFactory.getInstance(CloudEventHandler.class.getCanonicalName()))
Review Comment:
When event handle is not registered then unregister should be a no-op. It is
valid to add a test case but it probably won't be a negative test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
