qqu0127 commented on code in PR #2126:
URL: https://github.com/apache/helix/pull/2126#discussion_r886122210
##########
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java:
##########
@@ -904,8 +904,8 @@ private void handleEvent(ClusterEvent event,
BaseControllerDataProvider dataProv
pipeline.finish();
} catch (Exception e) {
logger.error(
- "Exception while executing {} pipeline for cluster {}. Will not
continue to next pipeline",
- dataProvider.getPipelineName(), _clusterName, e);
+ "Exception while executing " + dataProvider.getPipelineName() + "
pipeline for cluster "
+ + _clusterName + ". Will not continue to next pipeline.
Exception: " + e);
Review Comment:
We can use `logger.error(msg, e)` to include the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
