[GitHub] [helix] micahstubbs opened a new pull request, #2131: Upgrade helix-front to Angular 12.2

Wed, 01 Jun 2022 16:05:02 -0700 


micahstubbs opened a new pull request, #2131:
URL: https://github.com/apache/helix/pull/2131

   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the 
PR description:
   
   Fix #2112 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   This PR upgrades helix-front to Angular 12.2.
   
   This PR completely contains earlier helix-front upgrade PRs #2111, #2104, 
#2094, #2092, #2087, #2083, and #2078. These previous Angular major-version PRs 
should be merged first.
   
   ### Tests
   
   -Let's test the upgrade from Angular 11.2 to Angular 12.2.
   
   - [x] `npm install` works
   - [x] `npm run type:check:watch` shows 0 TypeScript errors
   - [x] `npm run lint` runs and passes `All files pass linting.`
   - [x] `npm run build` works
   - [x] `npm start` works, with 0 errors in the browser console.
   - [x] `npm run test` runs and passes.
   
   
   `npm start` works as expected, and recognizes our proxy config in 
`proxy.conf.json`. 
   
   
   <img width="726" alt="Screen Shot 2022-05-23 at 7 16 09 PM" 
src="https://user-images.githubusercontent.com/2119400/169937408-5cd2573d-1f8e-4092-a8a6-9bcf9266034b.png";>
   
   
   Helix UI renders with 0 errors in the browser console.  
   
   `npm run test` results
   
   <img width="806" alt="Screen Shot 2022-05-23 at 7 40 40 PM" 
src="https://user-images.githubusercontent.com/2119400/169937681-86b592fa-0333-478b-a7bb-5cc8a3dd2db0.png";>
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation in the 
following wiki page:
   
   Not applicable since this PR does not contain new functionality, only 
tooling and dependency upgrades.
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   
   Not applicable since this PR does not make any changes to the Java codebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to