micahstubbs commented on code in PR #2125:
URL: https://github.com/apache/helix/pull/2125#discussion_r888293702
##########
helix-front/client/app/dashboard/dashboard.component.ts:
##########
@@ -172,17 +168,18 @@ export class DashboardComponent implements OnInit,
AfterViewInit, OnDestroy {
.subscribe(
result => {
_.forEach(result, (resource) => {
- const newId = this.visNetworkData.nodes.getLength() + 1;
+ const lastId = this.nodes.length;
+ const newId = this.nodes.length + 1;
this.resourceToId[resource.name] = newId;
- this.visNetworkData.nodes.add({
+ (this.visNetworkData.nodes as
Node[])[this.visNetworkData.nodes.length] = {
Review Comment:
These changes are to update to ngx-vis major version 3, which shipped
breaking changes to it's API. Details here:
https://github.com/apache/helix/issues/2092#issuecomment-1125486970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
