micahstubbs commented on code in PR #2145:
URL: https://github.com/apache/helix/pull/2145#discussion_r893871834
##########
helix-front/pom.xml:
##########
@@ -92,13 +94,13 @@
<execution>
<id>build</id>
+ <phase>process-test-resources</phase>
<goals>
- <goal>npm</goal>
+ <goal>yarn</goal>
</goals>
<configuration>
- <arguments>run-script build</arguments>
+ <arguments>build</arguments>
Review Comment:
The syntax is different between yarn and npm.
https://classic.yarnpkg.com/en/docs/cli/run
Ah! it looks like this should be `run build`. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
