micahstubbs opened a new pull request, #2151: URL: https://github.com/apache/helix/pull/2151
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: fix #2150 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: This PR removes the direct dependency on tsickle, which it turns out [is no longer necessary](https://github.com/apache/helix/issues/2150#issuecomment-1155973470). This PR also updates the build max warning to 3.47MB which is 3554kb. Finally, this PR adds the following direct dependencies in order to fix a subsequent yarn build failure that occurred after removing tsickle as a direct dependency: `yarn add ajv-formats && yarn add [email protected]`. ### Tests - [x] The following tests are written for this issue: No new tests. Existing tests pass. Let's test removing `tsickle` as a direct dependency: - [x] `yarn` successfully installs dependencies - [x] `yarn type:check:watch` shows 0 TypeScript errors - [x] `yarn lint` runs and passes `All files pass linting.` - [x] `yarn build` works - [x] `yarn start` works, with 0 errors in the browser console. - [x] `yarn test` runs and passes. `yarn start` works as expected, and recognizes our proxy config in `proxy.conf.json`. The Helix UI renders with 0 errors in the browser console.  `yarn test` results  - The following is the result of the "mvn test" command on the appropriate module: There are no Maven tests configured for helix-front. In the details section, I share the output that appears when running `mvn test` for the `helix-front` module. In summary, everything builds, but there are no Maven tests configured, so none run. <details> ➜ helix-front git:(2150/tsickle-git-hash-bug) mvn test [INFO] Scanning for projects... [INFO] [INFO] --------------------< org.apache.helix:helix-front >-------------------- [INFO] Building Apache Helix :: Front End 1.0.5-SNAPSHOT [INFO] -------------------------------[ bundle ]------------------------------- [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ helix-front --- [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-java-version) @ helix-front --- [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-output-timestamp-property) @ helix-front --- [INFO] [INFO] --- jacoco-maven-plugin:0.8.6:prepare-agent (default) @ helix-front --- [INFO] argLine set to -javaagent:/.m2/repository/org/jacoco/org.jacoco.agent/0.8.6/org.jacoco.agent-0.8.6-runtime.jar=destfile=/helix/apache-helix/helix/helix-front/target/jacoco.exec [INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ helix-front --- [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4 [INFO] Copying 3 resources from 1 bundle. [INFO] [INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ helix-front --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Using 'UTF-8' encoding to copy filtered properties files. [INFO] skip non existing resourceDirectory /helix/apache-helix/helix/helix-front/src/main/resources [INFO] Copying 3 resources [INFO] [INFO] --- frontend-maven-plugin:1.12.1:install-node-and-yarn (install node and yarn) @ helix-front --- [INFO] Node v14.17.6 is already installed. [INFO] Yarn 1.22.18 is already installed. [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ helix-front --- [INFO] No sources to compile [INFO] [INFO] --- frontend-maven-plugin:1.12.1:yarn (yarn install) @ helix-front --- [INFO] Running 'yarn install' in /helix/apache-helix/helix/helix-front [INFO] yarn install v1.22.18 [INFO] [1/5] Validating package.json... [INFO] [2/5] Resolving packages... [INFO] success Already up-to-date. [INFO] Done in 0.54s. [INFO] [INFO] --- maven-bundle-plugin:5.1.4:manifest (bundle-manifest) @ helix-front --- [INFO] Writing manifest: /helix/apache-helix/helix/helix-front/target/classes/META-INF/MANIFEST.MF [INFO] [INFO] --- maven-resources-plugin:3.2.0:testResources (default-testResources) @ helix-front --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Using 'UTF-8' encoding to copy filtered properties files. [INFO] skip non existing resourceDirectory /helix/apache-helix/helix/helix-front/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- frontend-maven-plugin:1.12.1:yarn (build) @ helix-front --- [INFO] Running 'yarn run build' in /helix/apache-helix/helix/helix-front [INFO] yarn run v1.22.18 [INFO] $ rm -rf dist && mkdir dist && ng build --aot --configuration production && tsc -p server [INFO] - Generating browser application bundles (phase: setup)... [INFO] Processing legacy "View Engine" libraries: [INFO] - ngx-window-token [es2015/esm2015] (https://github.com/maxisam/ngx-window-token) [INFO] - ngx-vis [es2015/esm2015] (git+https://github.com/visjs/ngx-vis.git) [INFO] - @swimlane/ngx-datatable [es2015/esm2015] (git+https://github.com/swimlane/ngx-datatable.git) [INFO] - ngx-json-viewer [es2015/esm2015] (git+https://github.com/hivivo/ngx-json-viewer.git) [INFO] - ngx-clipboard [es2015/esm2015] (https://github.com/maxisam/ngx-clipboard) [INFO] - @swimlane/ngx-charts [es2015/esm2015] (git+https://github.com/swimlane/ngx-charts.git) [INFO] Encourage the library authors to publish an Ivy distribution. [INFO] ✔ Browser application bundle generation complete. [INFO] ✔ Browser application bundle generation complete. [INFO] - Copying assets... [INFO] ✔ Copying assets complete. [INFO] - Generating index html... [INFO] ✔ Index html generation complete. [INFO] [INFO] Initial Chunk Files | Names | Raw Size | Estimated Transfer Size [INFO] main.5842a830071c3192.js | main | 3.10 MB | 557.65 kB [INFO] styles.cb978aee76fa1bd8.css | styles | 303.52 kB | 36.67 kB [INFO] polyfills.ff4780c306116b22.js | polyfills | 73.55 kB | 23.23 kB [INFO] runtime.93d35a893ab74671.js | runtime | 1.30 kB | 694 bytes [INFO] [INFO] | Initial Total | 3.47 MB | 618.24 kB [INFO] [INFO] Build at: 2022-06-15T05:00:24.507Z - Hash: 0cf901e62f73928b - Time: 27473ms [INFO] [INFO] Warning: /helix/apache-helix/helix/helix-front/node_modules/@swimlane/ngx-graph/fesm2015/swimlane-ngx-graph.mjs depends on 'dagre'. CommonJS or AMD dependencies can cause optimization bailouts. [INFO] For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies [INFO] [INFO] Warning: /helix/apache-helix/helix/helix-front/node_modules/@swimlane/ngx-graph/fesm2015/swimlane-ngx-graph.mjs depends on 'webcola'. CommonJS or AMD dependencies can cause optimization bailouts. [INFO] For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies [INFO] [INFO] Warning: /helix/apache-helix/helix/helix-front/node_modules/ngx-vis/__ivy_ngcc__/fesm2015/ngxvis.js depends on 'vis-network'. CommonJS or AMD dependencies can cause optimization bailouts. [INFO] For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies [INFO] [INFO] Warning: /helix/apache-helix/helix/helix-front/node_modules/ngx-vis/__ivy_ngcc__/fesm2015/ngxvis.js depends on 'vis-timeline'. CommonJS or AMD dependencies can cause optimization bailouts. [INFO] For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies [INFO] [INFO] [INFO] Done in 32.65s. [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ helix-front --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @ helix-front --- [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 41.310 s [INFO] Finished at: 2022-06-14T22:00:27-07:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project helix-front: suiteXmlFiles is configured, but there is no TestNG dependency -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException </details> ### Changes that Break Backward Compatibility This PR does not contain any backwards incompatible changes. ### Documentation. This PR fixes a bug. It does not add new functionality. ### Commits -[x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality -[x] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) No Java changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
