rabashizade commented on code in PR #2153:
URL: https://github.com/apache/helix/pull/2153#discussion_r898351627
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java:
##########
@@ -187,6 +189,13 @@ public Response createCluster(@PathParam("clusterId")
String clusterId,
LOG.error("Failed to create cluster {}. Exception: {}.", clusterId, ex);
return serverError(ex);
}
+
+ try {
Review Comment:
If we perform this before the cluster creation, then if ACL fails the
cluster isn't created either. I'm not sure which one is the better option
though, a cluster without ACL or an ACL without a cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
