micahstubbs opened a new pull request, #2157:
URL: https://github.com/apache/helix/pull/2157

   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the 
PR description:
   
   Fix #2143
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   Today, there is limited code style enforcement in helix-front, leading to 
unnecessary contributor toil to maintain consistent code style and formatting.
   
   This PR adds automatic code formatting for helix-front using 
https://prettier.io/ and yarn scripts. This PR adds automatic formatting for 
JavaScript, TypeScript, JSON, and HTML files in the helix-front module.
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   No new tests, tooling-only PR.
   
   - [x] The following is the result of the "mvn test" command on the 
appropriate module:
   
   There are no Maven Tests for helix-front.
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - [x] My PR contains changes that break backward compatibility or previous 
assumptions for certain methods or API. They include:
   
   No backwards incompatible changes
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in 
their subject lines. In addition, my commits follow the guidelines from "[How 
to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   
   No Java code changes. This PR adds analogous code formatting for JavaScript, 
TypeScript, JSON, and HTML files in the helix-front module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to