xyuanlu commented on code in PR #2137:
URL: https://github.com/apache/helix/pull/2137#discussion_r899768288
##########
helix-core/src/main/java/org/apache/helix/HelixManagerProperty.java:
##########
@@ -80,27 +86,32 @@ public long getHealthReportLatency() {
return _healthReportLatency;
}
- public RealmAwareZkClient.RealmAwareZkConnectionConfig
getZkConnectionConfig() {
- return _zkConnectionConfig;
+ public RealmAwareZkClient.RealmAwareZkConnectionConfig
getRealmAwareZkConnectionConfig() {
+ return _realmAwareZkConnectionConfig;
}
public RealmAwareZkClient.RealmAwareZkClientConfig getZkClientConfig() {
return _zkClientConfig;
}
+ public HelixZkClient.ZkConnectionConfig getZkConnectionConfig() {
+ return _zkConnectionConfig;
+ }
+
public static class Builder {
private String _version;
private long _healthReportLatency;
private HelixCloudProperty _helixCloudProperty;
- private RealmAwareZkClient.RealmAwareZkConnectionConfig
_zkConnectionConfig;
+ private RealmAwareZkClient.RealmAwareZkConnectionConfig
_realmAwareZkConnectionConfig;
private RealmAwareZkClient.RealmAwareZkClientConfig _zkClientConfig;
+ private HelixZkClient.ZkConnectionConfig _zkConnectionConfig;
public Builder() {
}
public HelixManagerProperty build() {
return new HelixManagerProperty(_version, _healthReportLatency,
_helixCloudProperty,
- _zkConnectionConfig, _zkClientConfig);
+ _realmAwareZkConnectionConfig, _zkClientConfig, _zkConnectionConfig);
Review Comment:
Question: For this public function, shall we keep the original signature and
add this as a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
