qqu0127 commented on code in PR #2190:
URL: https://github.com/apache/helix/pull/2190#discussion_r943971757
##########
helix-rest/src/main/java/org/apache/helix/rest/server/service/VirtualTopologyGroupService.java:
##########
@@ -89,11 +89,6 @@ public VirtualTopologyGroupService(HelixAdmin helixAdmin,
ClusterService cluster
*/
public void addVirtualTopologyGroup(String clusterName, Map<String, String>
customFields) {
// validation
- CloudConfig cloudConfig = _configAccessor.getCloudConfig(clusterName);
Review Comment:
Not really, virtual group API was first only supposed to run in cloud
environment, so `cloudConfig` was a prerequisite, now it's removed. There is no
information or dependency needed from cloudConfig. A closer thing to
feature-flag is `clusterConfig.isTopologyAwareEnabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
