qqu0127 commented on code in PR #2214: URL: https://github.com/apache/helix/pull/2214#discussion_r974661035
########## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/IZkChildListener.java: ########## @@ -29,17 +31,31 @@ * guaranteed that events on the path are missing (see http://zookeeper.wiki.sourceforge.net/ZooKeeperWatches). An * implementation of this class should take that into account. * + * Deprecated: This interface is kept to maintain backward compatibility, please use {@link IZkChildEventListener}. */ -public interface IZkChildListener { +@Deprecated +public interface IZkChildListener extends IZkChildEventListener { Review Comment: How is that? There is a default implementation of the new method. There is no breaking change for existing classes, `ZkHelixClusterVerifier` is an example -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
