somecodemonkey commented on code in PR #2222:
URL: https://github.com/apache/helix/pull/2222#discussion_r977039874
##########
helix-front/server/controllers/helix.ts:
##########
@@ -50,9 +56,9 @@ export class HelixCtrl {
};
request[method](options, (error, response, body) => {
if (error) {
- res.status(500).send(error);
+ res.status(response.statusCode || 500).send(error);
Review Comment:
Is there ever a case where the statusCode will be empty?
##########
helix-front/server/controllers/helix.ts:
##########
@@ -41,6 +42,12 @@ export class HelixCtrl {
if (apiPrefix) {
const realUrl = apiPrefix + url.replace(`/${helixKey}`, '');
+ console.log('realUrl from helix api proxy');
+ console.log(realUrl);
+ console.log('');
+ console.log('request body');
+ console.log(req.body);
Review Comment:
Not against this but one option here is to gate this behind a local storage
toggle for debugging. It would prevent unnecessarily logging at all times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
