qqu0127 commented on PR #2223: URL: https://github.com/apache/helix/pull/2223#issuecomment-1258500893
> Thanks @qqu0127 for quick turn-around. Looks good to me. May be in future, we should add a test-class which extends BaseAccessor and just to make sure we don't cause regression with BaseAccessor. Thanks @desaikomal , this is true. But I'm afraid it's still more on developer's own awareness. Normally people will fix all compile error caused by the interface change. That's end of story for the repo itself, but not for external user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
