xyuanlu commented on code in PR #2239:
URL: https://github.com/apache/helix/pull/2239#discussion_r1007180484
##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java:
##########
@@ -662,4 +654,124 @@ public void testClose() {
Assert.assertEquals(ex.getMessage(), "FederatedZkClient is closed!");
}
}
+
+ /**
+ * Test that zk multi works for op.create.
+ */
Review Comment:
I think since this test class already extends RealmAwareZkClientTestBase,
the following tests should already be included.
We could add test cases that are specific to federatedZKClient
implementation of multi. For example, try to create multiple ZNode that do not
belongs to one realm and expect a failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
