NealSun96 commented on code in PR #2189:
URL: https://github.com/apache/helix/pull/2189#discussion_r1025691812
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java:
##########
@@ -410,43 +429,22 @@ protected List<HelixRebalanceException.Type>
failureTypesToPropagate() {
* @param algorithm
* @throws HelixRebalanceException
*/
- private void globalRebalance(ResourceControllerDataProvider clusterData,
- Map<String, Resource> resourceMap, final CurrentStateOutput
currentStateOutput,
- RebalanceAlgorithm algorithm)
- throws HelixRebalanceException {
+ private void globalRebalance(ResourceControllerDataProvider clusterData,
Map<String, Resource> resourceMap,
+ final CurrentStateOutput currentStateOutput, RebalanceAlgorithm
algorithm) throws HelixRebalanceException {
_changeDetector.updateSnapshots(clusterData);
// Get all the changed items' information. Filter for the items that have
content changed.
- final Map<HelixConstants.ChangeType, Set<String>> clusterChanges =
- _changeDetector.getAllChanges();
-
- if (clusterChanges.keySet().stream()
Review Comment:
Moving cluster model generation to the concrete and async doGlobalRebalance
to improve performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
