xyuanlu commented on code in PR #2290:
URL: https://github.com/apache/helix/pull/2290#discussion_r1028595153
##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java:
##########
@@ -440,13 +323,8 @@ public void testZKHelixManagerCloudConfig() throws
Exception {
InstanceConfig instanceConfig = new InstanceConfig(participantName);
_zkHelixAdmin.addInstance(clusterName, instanceConfig);
- RealmAwareZkClient.RealmAwareZkConnectionConfig.Builder
connectionConfigBuilder =
- new RealmAwareZkClient.RealmAwareZkConnectionConfig.Builder();
- // Try with a connection config without ZK realm sharding key set (should
fail)
- RealmAwareZkClient.RealmAwareZkConnectionConfig invalidZkConnectionConfig =
- connectionConfigBuilder.build();
- RealmAwareZkClient.RealmAwareZkConnectionConfig validZkConnectionConfig =
- connectionConfigBuilder.setZkRealmShardingKey("/" +
clusterName).build();
+ createZkConnectionConfigs(clusterName);
Review Comment:
We dont need to call this again. It is already populated in previous test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
