[GitHub] [helix] helix-bot commented on pull request #2317: show errors from instance detail page instance remove action in the UI

Tue, 13 Dec 2022 11:29:27 -0800 


helix-bot commented on PR #2317:
URL: https://github.com/apache/helix/pull/2317#issuecomment-1349583085

   Hi @mgao0, thank you for the review.
   
   We should clarify: there are no failed tests. The 10 skipped tests were 
skipped with by the original author @hivivo 5 years ago. Here is a [git 
blame](https://github.com/apache/helix/blame/master/helix-front/src/app/cluster/cluster-detail/cluster-detail.component.spec.ts#L28)
 link that shows an example of this old, unchanged skip command.
   
   <img width="905" alt="Screen Shot 2022-12-13 at 11 24 37 AM" 
src="https://user-images.githubusercontent.com/117035117/207426474-36ea30fa-28ca-4a5a-b6ab-06fd92f00e4c.png";>
   
   
   This PR does not change those old skip commands. The specific skip command 
used is the `xit()` alias for `test.skip(name, fn)` from the unit testing 
library jest:
   
   https://jestjs.io/docs/api#testskipname-fn
   
   <img width="830" alt="Screen Shot 2022-12-13 at 11 26 59 AM" 
src="https://user-images.githubusercontent.com/117035117/207426732-619f8a0b-5b27-4eb5-a080-7b467a94316d.png";>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to