qqu0127 commented on code in PR #2333:
URL: https://github.com/apache/helix/pull/2333#discussion_r1063853153
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -240,17 +240,18 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
LOG.info("ZkClient monitor key or type is not provided. Skip
monitoring.");
}
- connect(connectionTimeout, this);
-
- try {
Review Comment:
This is moved to inside `connect()`, you can look at the code below. Those
two things should be combined and always happen together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
