xyuanlu commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1068433562


##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -50,12 +55,27 @@ public ZkMetaClient(ZkMetaClientConfig config) {
 
   @Override
   public void create(String key, Object data) {
-
+    try {
+      create(key, data, EntryMode.PERSISTENT);
+    } catch (Exception e) {
+      throw new MetaClientException(e);
+    }
   }
 
   @Override
-  public void create(String key, Object data, EntryMode mode) {
-
+  public void create(String key, Object data, MetaClientInterface.EntryMode 
mode) {
+    int zkFlag = -1;
+    if (mode.name().equals(EntryMode.PERSISTENT.name())) {
+      zkFlag = 0;

Review Comment:
   Maybe a simple translator class will be helpful. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to