qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1069643019
########## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ########## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.google.common.annotations.VisibleForTesting; +import java.util.Collection; +import java.util.Collections; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.CopyOnWriteArraySet; +import java.util.concurrent.locks.ReentrantLock; +import java.util.function.Consumer; + + +/** + * A thread-safe container wrapper class for Listeners registered to ZkClient. + * It stores 2 types of listener separately, one-time listener and persistent listener. The former ones are removed + * right after its consumption, while the latter need to be explicitly removed. + * @param <T> the type of listener + */ +public class ListenerContainer<T> { + private final ReentrantLock _lock = new ReentrantLock(true); + private final Map<String, Set<T>> _persistentListener = new ConcurrentHashMap<>(); + private final Map<String, Set<T>> _onetimeListener = new ConcurrentHashMap<>(); + + /** + * Add listener to the container with specified key. + * @param key the key to register to + * @param listener the listener to register + * @param persistListener true if the listener is persistent + */ + public void addListener(String key, T listener, boolean persistListener) { + addListener(key, listener, persistListener ? _persistentListener : _onetimeListener); + } + + /** + * Remove listener from the container. + * This operation removes both one-time and persistent listener from the specified key. + * @param key the key to remove + * @param listener the listener to remove + */ + public void removeListener(String key, T listener) { + _lock.lock(); + try { + removeFromListenerMap(key, listener, _persistentListener); Review Comment: Thanks for the review @jiajunwang ! For your first point, this class is generics, it can support any type of listener already. Second, sync block might be better compared to the whole method, that should be equivalent. For locking it self, we need synchronization on most writes operation even if there are concurrent hashmap. Please see other comment for more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
