desaikomal commented on code in PR #2340:
URL: https://github.com/apache/helix/pull/2340#discussion_r1073113630


##########
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java:
##########
@@ -371,11 +374,12 @@ public void updateStateHandoffStats(MonitorState 
monitorState, long totalDuratio
 
   public void updateRebalancerStats(long numPendingRecoveryRebalancePartitions,
       long numPendingLoadRebalancePartitions, long 
numRecoveryRebalanceThrottledPartitions,
-      long numLoadRebalanceThrottledPartitions) {
+      long numLoadRebalanceThrottledPartitions, boolean 
rebalanceThrottledByErrorPartitio) {
     
_numPendingRecoveryRebalanceReplicas.updateValue(numPendingRecoveryRebalancePartitions);
     
_numPendingLoadRebalanceReplicas.updateValue(numPendingLoadRebalancePartitions);
     
_numRecoveryRebalanceThrottledReplicas.updateValue(numRecoveryRebalanceThrottledPartitions);
     
_numLoadRebalanceThrottledReplicas.updateValue(numLoadRebalanceThrottledPartitions);
+    
_rebalanceThrottledByErrorPartitionGauge.updateValue(rebalanceThrottledByErrorPartitio?
 1L : 0L);

Review Comment:
   so this is just boolean indicating throttled or not due to error partition?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to