Marcosrico commented on code in PR #2343:
URL: https://github.com/apache/helix/pull/2343#discussion_r1083092347
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -391,34 +380,13 @@ public int hashCode() {
}
}
- private static MetaClientException
translateZkExceptionToMetaclientException(ZkException e) {
- if (e instanceof ZkNodeExistsException) {
- return new MetaClientNoNodeException(e);
- } else if (e instanceof ZkBadVersionException) {
- return new MetaClientBadVersionException(e);
- } else if (e instanceof ZkTimeoutException) {
- return new MetaClientTimeoutException(e);
- } else if (e instanceof ZkInterruptedException) {
- return new MetaClientInterruptException(e);
- } else {
- return new MetaClientException(e);
- }
- }
-
- private static EntryMode convertZkEntryMode(long ephemeralOwner) {
- EphemeralType zkEphemeralType = EphemeralType.get(ephemeralOwner);
- switch (zkEphemeralType) {
- case VOID:
- return EntryMode.PERSISTENT;
- case CONTAINER:
- return EntryMode.CONTAINER;
- case NORMAL:
- return EntryMode.EPHEMERAL;
- // TODO: TTL is not supported now.
- //case TTL:
- // return EntryMode.TTL;
- default:
- throw new IllegalArgumentException(zkEphemeralType + " is not
supported.");
- }
+ @Override
+ public List<OpResult> transactionOP(Iterable<Op> iterable) {
Review Comment:
Good catch. The metaclient interface has it as ops as well so it only makes
sense to be consistent with the naming too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
