junkaixue commented on code in PR #2346:
URL: https://github.com/apache/helix/pull/2346#discussion_r1084471694
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/IZkChildListener.java:
##########
@@ -42,4 +44,9 @@ public interface IZkChildListener {
* @throws Exception
*/
public void handleChildChange(String parentPath, List<String>
currentChilds) throws Exception;
+
+ default void handleChildChange(String parentPath, List<String>
currentChilds, Watcher.Event.EventType eventType)
Review Comment:
NIT: let's add java doc here.
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/adapter/ChildListenerAdapter.java:
##########
@@ -0,0 +1,75 @@
+package org.apache.helix.metaclient.impl.zk.adapter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.List;
+import org.apache.helix.metaclient.api.ChildChangeListener;
+import org.apache.helix.zookeeper.zkclient.IZkChildListener;
+import org.apache.zookeeper.Watcher;
+
+
+/**
+ * A adapter class to transform {@link ChildChangeListener} to {@link
IZkChildListener}.
+ */
+public class ChildListenerAdapter implements IZkChildListener {
+ private final ChildChangeListener _listener;
+
+ public ChildListenerAdapter(ChildChangeListener listener) {
+ _listener = listener;
+ }
+
+ @Override
+ public void handleChildChange(String parentPath, List<String> currentChilds)
throws Exception {
+ throw new UnsupportedOperationException("handleChildChange(String
parentPath, List<String> currentChilds) "
+ + "is not supported");
Review Comment:
Is this the recursive persist subscribe? Better have some documentation for
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
