rahulrane50 commented on code in PR #2344:
URL: https://github.com/apache/helix/pull/2344#discussion_r1084629930
##########
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java:
##########
@@ -109,9 +157,21 @@ public class ClusterStatusMonitor implements
ClusterStatusMonitorMBean {
private final Map<String, JobMonitor> _perTypeJobMonitorMap = new
ConcurrentHashMap<>();
+ /**
+ * Missing top state resource map:
resourceName-><PartitionName->startTimeOfMissingTopState>
+ */
+ private final Map<String, Map<String, Long>> _missingTopStateResourceMap =
new ConcurrentHashMap<>();
+ private final AsyncMissingTopStateMonitor _asyncMissingTopStateMonitor = new
AsyncMissingTopStateMonitor(_missingTopStateResourceMap);
+
public ClusterStatusMonitor(String clusterName) {
_clusterName = clusterName;
_beanServer = ManagementFactory.getPlatformMBeanServer();
+ /**
+ * Start a async thread for each cluster which keeps monitoring missing
top states of any resource for a cluster.
+ * This thread will keep on iterating over resources and report
missingTopStateDuration for them until there are at
+ * least one resource with missing top state for a cluster.
+ */
+ _asyncMissingTopStateMonitor.start();
Review Comment:
Good question! I think it has to be stopped/interrupted for sure by
ClusterStatusMonitor when it's cleaning up all state but main process
(ClusterStatusMonitor) do not have to wait until it's finished because it's
async long running thread and metrics reporting is never ending job so it's
lifecycle can be tied with main process. Let me know if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
