xyuanlu commented on code in PR #2344:
URL: https://github.com/apache/helix/pull/2344#discussion_r1094940522
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -85,6 +85,9 @@ private void
updateTopStateStatus(ResourceControllerDataProvider cache,
if (cache.getClusterConfig() != null) {
durationThreshold =
cache.getClusterConfig().getMissTopStateDurationThreshold();
}
+ if (clusterStatusMonitor != null) {
+
clusterStatusMonitor.updateMissingTopStateDurationThreshold(durationThreshold);
Review Comment:
I am not sure if we can assume that. Normally we have default value and
user can set -1 if they want to disable this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
