desaikomal commented on code in PR #2365:
URL: https://github.com/apache/helix/pull/2365#discussion_r1095986980
##########
meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClient.java:
##########
@@ -333,16 +332,17 @@ private static ZkServer startZkServer(final String
zkAddress) {
}
/**
- * Test that zk transactional operation works for zkmetaclient operations
create,
- * delete, and set.
+ * Transactional op calls zk.multi() with a set of ops (operations)
Review Comment:
Great comments
##########
meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClient.java:
##########
@@ -57,9 +57,8 @@ public class TestZkMetaClient {
private static final String ZK_ADDR = "localhost:2183";
private static final int DEFAULT_TIMEOUT_MS = 1000;
private static final String ENTRY_STRING_VALUE = "test-value";
- protected static final String TRANSACTION_TEST_KEY_PREFIX =
"/sharding-key-0";
- protected static String PARENT_PATH = TRANSACTION_TEST_KEY_PREFIX +
"/RealmAwareZkClient";
- protected static final String TEST_INVALID_PATH =
TRANSACTION_TEST_KEY_PREFIX + "_invalid" + "/a/b/c";
+ protected static String PARENT_PATH = "/transactionOpTestPath";
+ protected static final String TEST_INVALID_PATH = "_invalid" + "/a/b/c";
Review Comment:
nit: just curious, why not "_invalid/a/b/c" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
