xyuanlu commented on code in PR #2372: URL: https://github.com/apache/helix/pull/2372#discussion_r1105124533
########## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClientAsyncCallback.java: ########## @@ -0,0 +1,116 @@ +package org.apache.helix.metaclient.impl.zk; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.helix.metaclient.api.AsyncCallback; +import org.apache.helix.metaclient.api.MetaClientInterface; +import org.apache.helix.metaclient.impl.zk.util.ZkMetaClientUtil; +import org.apache.helix.zookeeper.zkclient.callback.ZkAsyncCallbacks; + + +/** + * Wrapper class for metaclient.api.AsyncCallback. + * This wrapper class extends zk callback class. It has an object of user defined + * metaclient.api.AsyncCallback. + * Each callback will do default retry defined in ZkAsyncCallbacks. (defined in ZkAsyncCallbacks) + * + * ZkClient execute async callbacks at zkClient main thead, retry is handles in a separate retry + * thread. In our first version of implementation, we will keep similar behavior and have + * callbacks executed in ZkClient event thread, and reuse zkclient retry logic. + */ +public class ZkMetaClientAsyncCallback extends ZkAsyncCallbacks { + + public static class ZkMetaClientCreateCallbackHandler extends CreateCallbackHandler { + AsyncCallback.VoidCallback _userCallback; + + public ZkMetaClientCreateCallbackHandler(AsyncCallback.VoidCallback cb) { + _userCallback = cb; + } + + @Override + public void handle() { + // TODO: the processResult is changed in another PR. Will remove the `null` param when + // dependent PR is merged + _userCallback.processResult(getRc(), getPath(), null); + } + + } + + public static class ZkMetaClientDeleteCallbackHandler extends DeleteCallbackHandler { Review Comment: No. We probably keep the current behavior of Helix ZkAsyncCallbacksHandlers. It will do retry when operation failed with connection error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
