mgao0 commented on code in PR #2380:
URL: https://github.com/apache/helix/pull/2380#discussion_r1113488505
##########
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java:
##########
@@ -191,8 +190,7 @@ public HelixTaskExecutor(ParticipantStatusMonitor
participantStatusMonitor,
_batchMessageExecutorService = Executors.newCachedThreadPool();
_monitor.createExecutorMonitor("BatchMessageExecutor",
_batchMessageExecutorService);
- _resourcesThreadpoolChecked = Collections.newSetFromMap(new
ConcurrentHashMap<>());
- _transitionTypeThreadpoolChecked = Collections.newSetFromMap(new
ConcurrentHashMap<>());
+ _threadpoolChecked = Collections.newSetFromMap(new ConcurrentHashMap<>());
Review Comment:
Previously we use different sets to do search for different property-based
threadpool. Right now I'm combining them into one set, but making the key
generation structural, so we maintain the capability of searching threadpool in
different levels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]