rahulrane50 commented on code in PR #2381:
URL: https://github.com/apache/helix/pull/2381#discussion_r1115193727
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -471,6 +474,7 @@ private void
reportTopStateComesBack(ResourceControllerDataProvider cache, Map<S
}
}
+ // TODO: why are we checking if handoff happened within threshold here? it
should be reported either way.
Review Comment:
@junkaixue i have a question here. Why are we updating topstate handoff
duration only if it's within threshold. This means that if threshold is set to
"x" ms and any partition's top state has recovered beyond "x" ms then we would
not report it. Basically same behaviour as reportSingleTopStateHandoff. (If my
understanding is correct then i can remove this, i have also changed test to
verify this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
