xyuanlu commented on code in PR #2381:
URL: https://github.com/apache/helix/pull/2381#discussion_r1117489683
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -471,6 +474,7 @@ private void
reportTopStateComesBack(ResourceControllerDataProvider cache, Map<S
}
}
+ // TODO: why are we checking if handoff happened within threshold here? it
should be reported either way.
Review Comment:
If handoff happened within timeout, Helix treat it as regular handoff.
If handoff happened longer than timeout, Helix treat it as handoff failure.
I think there may be different metrics counting this. Please read it though and
see how the new metrics fit into picture.
I would prefer not leave question as comments in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
