xyuanlu commented on PR #2409: URL: https://github.com/apache/helix/pull/2409#issuecomment-1478944076
> multiple metaclient/zkmetaclient objects and they all can use same monitor thread Thanks for the review. I would prefer each ZkMetaClient has one monitor thread because 1. Each zkmetaclient objects need to monitor reconnect process and have its own counter with unique start time. It is hard to coordinate using one thread. 2. We need to maintain the lifecycle of this monitor thread. Having multiple zkmetaclient objects and they all can use same monitor thread would be hard to manage and cause thread leak. 3. We need this monitor because ZkClient does retry infinity. Other underlying metadata service may not have same reconnect protocol. It only applies to ZooKeeper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
