[GitHub] [helix] cliffordfajardo commented on a diff in pull request #2417: Setup optional proxy agent for use with App Insights

Wed, 22 Mar 2023 18:11:47 -0700 


cliffordfajardo commented on code in PR #2417:
URL: https://github.com/apache/helix/pull/2417#discussion_r1145566608


##########
helix-front/server/config.example.ts:
##########
@@ -56,3 +56,9 @@ export const TOKEN_EXPIRATION_KEY: string = 'expires';
  * This key can be null or a string.
  */
 export const APP_INSIGHTS_CONNECTION_STRING: string | null = null;
+
+/**
+ * An optional proxy url
+ *
+ */
+export const PROXY_URL: string = 'www.example.com';

Review Comment:
   I think these values from [PR 9 of 
helix-ui](https://linkedin.ghe.com/multiproduct/helix-ui/pull/9/files) need to 
go in this file?
   ![CleanShot 2023-03-22 at 18 10 
38@2x](https://user-images.githubusercontent.com/6743796/227073212-a8a4351e-6368-4de3-b414-84bc68ad076c.png)
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to