xyuanlu commented on code in PR #2429: URL: https://github.com/apache/helix/pull/2429#discussion_r1158110594
########## meta-client/src/main/java/org/apache/helix/metaclient/recipes/lock/LockInfo.java: ########## @@ -0,0 +1,250 @@ +package org.apache.helix.metaclient.recipes.lock; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.time.Duration; +import java.time.temporal.ChronoUnit; +import org.apache.helix.zookeeper.datamodel.ZNRecord; + + +/** + * This structure represents a Lock node information, implemented using ZNRecord + */ +public class LockInfo { + + // Default values for each attribute if there are no current values set by user + public static final String DEFAULT_LOCK_ID_TEXT = ""; + public static final String DEFAULT_OWNER_ID_TEXT = ""; + public static final String DEFAULT_CLIENT_ID_TEXT = ""; + public static final String DEFAULT_CLIENT_DATA = ""; + public static final long DEFAULT_GRANTED_AT_LONG = -1L; + public static final long DEFAULT_LAST_RENEWED_AT_LONG = -1L; + public static final Duration DEFAULT_TIMEOUT_DURATION = Duration.ofMillis(-1L); + private static final String ZNODE_ID = "LOCK"; + private final ZNRecord _record; + + /** + * The keys to lock information + */ + public enum LockInfoAttribute { + LOCK_ID, + OWNER_ID, + CLIENT_ID, + //CLIENT_DATA is a string that represents the serialized object passed in from the user. Review Comment: nit, inline comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
