xyuanlu commented on code in PR #2432:
URL: https://github.com/apache/helix/pull/2432#discussion_r1171922713
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -1313,7 +1354,7 @@ private void fireAllEvents(WatchedEvent event) {
* are deleted before the last page is fetched. The upstream caller should
be able to handle this.
*/
public List<String> getChildren(String path) {
- return getChildren(path, hasListeners(path));
+ return getChildren(path, (hasListeners(path) && !_usePersistWatcher));
Review Comment:
Good suggestion! Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
